Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distortion_corrector cannot compensate point cloud while passing over speed bump #4961

Closed
3 tasks done
mebasoglu opened this issue Sep 12, 2023 · 5 comments
Closed
3 tasks done
Labels
type:new-feature New functionalities or additions, feature requests.

Comments

@mebasoglu
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

While passing over a speed bump, the point cloud has a strange behaviour and distortion corrector cannot fix it. This causes ghost points and ground remover cannot delete them. (#3673)

Here is a video of VLS-128 driving on a speed bump:

speed_bump.mp4

Expected behavior

Distortion corrector should compensate point cloud while driving over speed bump.

Actual behavior

Distortion corrector cannot fix point cloud on speed bump.

Steps to reproduce

Drive your vehicle on speed bump with a lidar such as VLS-128 and you will see the behaviour.

Versions

  • OS: Ubuntu 22.04
  • ROS 2 Humble
  • Up-to-date main branch of Autoware

Possible causes

No response

Additional context

No response

@VRichardJP
Copy link
Contributor

VRichardJP commented Sep 12, 2023

Just to make sure, are you talking about the point cloud crack at road level here:

Screenshot_2023-09-13-08-24-48-246_org mozilla firefox-edit

@mebasoglu
Copy link
Contributor Author

Just to make sure, are you talking about the point cloud crack at road level here:

Screenshot_2023-09-13-08-24-48-246_org mozilla firefox-edit

Hello, yes, I am talking about that.

@VRichardJP
Copy link
Contributor

Indeed, current implementation has not been designed to handle speed bumps.
Distortion corrector only takes into account linear speed (twist_it->twist.linear.x) and yaw rate (imu_it->vector.z). To handle speed bumps, it would be necessary to check pitch rate as well (imu_it->vector.y).

I am not sure the math is much harder. However, while absolute linear and yaw acceleration stay usually low (i.e. speed and yaw rate are almost constant at scan level), pitch acceleration goes pretty high when the car hits a speed bump. So for the compensation to work properly, it would be necessary to have well synchronized sensors and high frequency IMU. If there is any delay in the measurement, you would end up with the wrong points being corrected, and the "corrected" result would be worse than the non-corrected one.

@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Sep 18, 2023
Copy link

stale bot commented Nov 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 17, 2023
@vividf
Copy link
Contributor

vividf commented Jul 12, 2024

This issue should be solved by the PR #7137 (comment)

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jul 12, 2024
@vividf vividf closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

4 participants