Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoware_core_component_interface_specs package #124

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Dec 12, 2024

Description

This creates a new autoware_core_component_interface_specs package in to Autoware Core.
This package is based on autoware_component_interface_specs. The main differences are the followings:

  • remove any interfaces from autoware_tier4_msgs since these are not official interface defined by AWF
  • remove ADAPI interfaces. Phase 1 of Autoware Core would be simple so I removed them for simplicity.
  • Add base class for interface definition with get_qos() function. Autoware Universe has autoware_interface_utils to provide similar utility function, but I thought that was too overwhelming for Autoware Core so I just provided the simple interface to help users declare publishers and subscribers.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Dec 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r force-pushed the add-autoware-component-interface-specs branch 2 times, most recently from 3f92a0e to 8aba5d9 Compare December 12, 2024 16:08
@mitsudome-r mitsudome-r marked this pull request as ready for review December 16, 2024 08:44
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 41.93548% with 36 lines in your changes missing coverage. Please review.

Project coverage is 64.95%. Comparing base (051d227) to head (fb905d6).

Files with missing lines Patch % Lines
...re_component_interface_specs/test/test_vehicle.cpp 33.33% 0 Missing and 12 partials ⚠️
...e_core_component_interface_specs/test/test_map.cpp 35.71% 0 Missing and 9 partials ⚠️
...mponent_interface_specs/test/test_localization.cpp 40.00% 0 Missing and 6 partials ⚠️
...e_component_interface_specs/test/test_planning.cpp 40.00% 0 Missing and 6 partials ⚠️
...component_interface_specs/test/test_perception.cpp 50.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   73.25%   64.95%   -8.30%     
==========================================
  Files          10       17       +7     
  Lines         172      234      +62     
  Branches       68      104      +36     
==========================================
+ Hits          126      152      +26     
  Misses         19       19              
- Partials       27       63      +36     
Flag Coverage Δ *Carryforward flag
differential 41.93% <41.93%> (?)
total 73.25% <ø> (ø) Carriedforward from 051d227

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant