Skip to content

Commit

Permalink
supress clang-tidy performance warn on async_send_request
Browse files Browse the repository at this point in the history
Signed-off-by: Alexey Panferov <[email protected]>
  • Loading branch information
lexavtanke committed Apr 19, 2024
1 parent cfabbab commit f07be46
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ void AutowareControlCenter::startup_callback()
using ServiceResponseFuture = rclcpp::Client<
autoware_control_center_msgs::srv::AutowareControlCenterDeregister>::SharedFuture;
// lambda for async request
// NOLINTNEXTLINE(performance-unnecessary-value-param)
auto response_received_callback = [this](const ServiceResponseFuture future) {
const auto & response = future.get();
RCLCPP_INFO(
Expand Down
4 changes: 2 additions & 2 deletions common/autoware_node/src/autoware_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ void AutowareNode::send_state(
req, std::bind(&AutowareNode::node_error_future_callback, this, std::placeholders::_1));
RCLCPP_INFO(get_logger(), "Send node state");
}

// NOLINTNEXTLINE(performance-unnecessary-value-param)
void AutowareNode::node_register_future_callback(AutowareNodeRegisterServiceResponseFuture future)
{
const auto & response = future.get();
Expand All @@ -179,7 +179,7 @@ void AutowareNode::node_register_future_callback(AutowareNodeRegisterServiceResp
RCLCPP_ERROR(get_logger(), "Failed to register node");
}
}

// NOLINTNEXTLINE(performance-unnecessary-value-param)
void AutowareNode::node_error_future_callback(AutowareNodeErrorServiceResponseFuture future)
{
const auto & response = future.get();
Expand Down

0 comments on commit f07be46

Please sign in to comment.