docs(support-guidelines): replace slack with discord references

[xmfcx]

I've also used https://shields.io/ for the interactive join link.

[xmfcx]

@kenji-miyake I've added Signed-off-by: M. Fatih Cırıt <[email protected]> to the commit description but DCO still fails.

[kenji-miyake]

@xmfcx I have two points to share with you.

1. I've changed the PR title to follow Conventional Commits and to use docs for the type instead of fix.

• However, since this repository doesn't have any code and it's just a documentation site, we can consider customizing the type.

2. If you have only one commit, the title of the PR and the title of the commit must be the same because the PR title won't be used when the PR is merged.

• However, if an admin can merge it carefully (edit the squashed message), this rule isn't mandatory.

[xmfcx]

@kenji-miyake https://github.com/autowarefoundation/autoware-documentation/runs/5594486445?check_suite_focus=true#step:2:20 this still fails because title is not fix: replace slack with discord references why did you change it to be docs(support-guidelines): replace slack with discord references? I didn't understand the reason sorry.

However, since this repository doesn't have any code and it's just a documentation site, we can consider customizing the type.

I understand when the merge is done, it won't care about the title. And it will use the commit message. And it will pass the CI.

But isn't it better to make it consistent with PR titles too?

[xmfcx]

Also I don't understand why commit sign-off (DCO) didn't work when I tried but it passes now.

[xmfcx]

Also I don't understand why commit sign-off (DCO) didn't work when I tried but it passes now.

Oh it says:

Commit sign-off was manually approved.

Why did you need to do that? @kenji-miyake ?

[kenji-miyake]

Why did you need to do that? @kenji-miyake ?

@xmfcx It seems the author and committer aren't the same.

[kenji-miyake]

@xmfcx

why did you change it to be docs(support-guidelines): replace slack with discord references? I didn't understand the reason sorry.

To follow this type definition.
https://github.com/commitizen/conventional-commit-types/blob/c3a9be4c73e47f2e8197de775f41d981701407fb/index.json#L12

I understand when the merge is done, it won't care about the title. And it will use the commit message. And it will pass the CI.

I'm sorry, I couldn't understand this part. 🤔

1 commit: It won't care about the PR title and use the commit title. It's an undesired behavior. So the CI requires the PR title and the commit title to be consistent.
2+ commits: It will care about the PR title.

But isn't it better to make it consistent with PR titles too?

Yes, it's better. So I fixed it and now semantic-pull-request has passed.

[xmfcx]

@xmfcx It seems the author and committer aren't the same.

Thanks, I was so confused!

[xmfcx]

To follow this type definition. https://github.com/commitizen/conventional-commit-types/blob/c3a9be4c73e47f2e8197de775f41d981701407fb/index.json#L12

Ah to follow that convention, I had made it into fix: i didn't realize there was also docs: there.