Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update docker installation #550

Closed
wants to merge 2 commits into from
Closed

Conversation

TimS120
Copy link

@TimS120 TimS120 commented May 13, 2024

Description

As discussed in that discussion https://github.com/orgs/autowarefoundation/discussions/4695 I updated the docker-development-setup-command, because the old command was no longer working. Also it's updated, that the first step is to clone the autoware-repository, because otherwise the setup-command wouldn't work.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

TimS120 and others added 2 commits May 13, 2024 20:22
@oguzkaganozt
Copy link
Contributor

oguzkaganozt commented May 17, 2024

@TimS120 thanks for the heads up for this important flaw, just simplified the run.sh mechanism and fix the issue when running dev environment with default workspace(which is current directory). You can find the related PRs here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants