Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list of strings for incremental unique_key #19

Merged
1 commit merged into from
Oct 10, 2022
Merged

Support list of strings for incremental unique_key #19

1 commit merged into from
Oct 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2022

Description

In dbt 1.1 support was added for unique_key to be a list of strings as well as just a string. The dry runner fails to validate the manifest if a project uses this feature. This PR changes the pydantic model to allow list of strings for unique_key. It also verifies that the snapshot model does not have a list of unique_key in case dbt adds this same feature to snapshot models and we need to update the node runner to handle this.

Fixes #18

Checklist:

  • I have run make verify and fixed any linting or test errors
  • I have added appropriate unit tests or if applicable an integration test
  • OPTIONAL: I have run make integration against a Big Query instance

@ghost ghost requested a review from georgim0 October 10, 2022 09:09
Copy link
Collaborator

@georgim0 georgim0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ghost ghost merged commit bd43459 into main Oct 10, 2022
@ghost ghost deleted the issue-3 branch October 24, 2022 13:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support multiple unique key (composite primary key)
2 participants