Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block_disk_not_default_options: creates new test case #4209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions qemu/tests/block_disk_not_default_options.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
from virttest import error_context, qemu_qtree

from provider import disk_utils
from provider.block_devices_plug import BlockDevicesPlug


@error_context.context_aware
def run(test, params, env):
"""
Test the disk non-default options.

Steps:
1. Boot a VM with packed=true and page-per-vq=true
2. Verify the packed and page-per-vq values
3. Do some basic I/O operation in the VM
4. Unplug and hotplug the disk
5. Do again a basic I/O operation

:param test: QEMU test object.
:param params: Dictionary with the test parameters.
:param env: Dictionary with test environment.
"""

def verify_non_default_options(option_key, expected_value):
"""Verify the non-default values.
:param option_key: the QEMU option to be checked.
:param expected_value: the QEMU option expected value.
"""
error_context.context(f"Verify {option_key} from monitor.", test.log.info)
qtree = qemu_qtree.QtreeContainer()
qtree_option_value = False
try:
qtree.parse_info_qtree(vm.monitor.info("qtree"))
except AttributeError:
test.cancel("Monitor doesn't support qtree skip this test")
error_msg = (
f"'{option_key}' value mismatch: expected %s but report from monitor is: %s"
)

for node in qtree.get_nodes():
if (
isinstance(node, qemu_qtree.QtreeDev)
and node.qtree.get(option_key) == expected_value
):
qtree_option_value = node.qtree.get(option_key)
error_context.context(
f"The qtree_option_value: {qtree_option_value}", test.log.debug
)

if qtree_option_value != expected_value:
error_msg = error_msg % (str(expected_value), qtree_option_value)
test.fail(error_msg)

vm = env.get_vm(params["main_vm"])
vm.verify_alive()
session = vm.wait_for_login(timeout=360)

qtree_check_images = params.get("qtree_check_images", "stg0").split()

mcasquer marked this conversation as resolved.
Show resolved Hide resolved
tmp_dir = params.get("tmp_dir", "/var/tmp/test")
disk_utils.execute_dd_on_disk_by_id(
params, qtree_check_images[0], session, tmp_dir, test
)

for image in qtree_check_images:
qtree_check_image = eval(params.get(f"qtree_check_{image}", "{}"))
if qtree_check_image:
for option_key in qtree_check_image:
error_context.base_context(
f"Options to verify: {option_key} {qtree_check_image[option_key]}",
test.log.debug,
)
verify_non_default_options(option_key, qtree_check_image[option_key])
else:
test.log.warning("There are no options to be checked in the qtree")

plug = BlockDevicesPlug(vm)
plug.unplug_devs_serial()
plug.hotplug_devs_serial()
disk_utils.execute_dd_on_disk_by_id(
params, qtree_check_images[0], session, tmp_dir, test
)
23 changes: 23 additions & 0 deletions qemu/tests/cfg/block_disk_not_default_options.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
- block_disk_not_default_options:
type = block_disk_not_default_options
only x86_64
start_vm = yes
images += " stg0"
boot_drive_stg0 = yes
image_name_stg0 = images/stg0
image_size_stg0 = 8G
remove_image_stg0 = yes
force_create_image_stg0 = yes
dd_cmd = "dd if=/dev/urandom of=test.txt bs=1M count=10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dd cmd should affect the disk with specified option.

blk_extra_params_stg0 = "serial=stg0"
fstype = "xfs"
variants:
- with_packed_and_ppv:
tmp_dir = /var/tmp/test
qtree_check_images = "stg0"
qtree_check_stg0 = '{"packed" : "true", "page-per-vq" : "true"}'
virtio_blk:
blk_extra_params_stg0 += ",packed=true,page-per-vq=true"
virtio_scsi:
bus_extra_params_stg0 = "packed=true,page-per-vq=true"
drive_bus_stg0 = 1
Loading