Make the minimum mapping block 1, not genesis #3247
Merged
+25
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
NingLin-P,
nazar-pc,
rg3l3dr and
vedhavyas
as code owners
1 task
nazar-pc
reviewed
Nov 21, 2024
crates/subspace-malicious-operator/src/bin/subspace-malicious-operator.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Nazar Mokrynskyi <[email protected]>
nazar-pc
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the minimum mapping block 1, rather than genesis.
During snap sync we don’t store the genesis block data, which was leading to errors when the archiver couldn’t find the genesis data to start mapping from. For background see paritytech/polkadot-sdk#5366
There are no mappings in the genesis block, so starting at 1 doesn’t change the mappings created by the node.
Code contributor checklist: