Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "No end judgment by exile" Option #400

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yurinakira
Copy link

Overview
Added "No end judgment by exile" option to allow some mods to continue the game even if the internal impostor is wiped out.
This solves the problem of the mute being unmuted by a lobby decision.

#364

I kept her PR as is and revised it to incorporate her points.

@kurokobo
Copy link
Collaborator

kurokobo commented Dec 5, 2023

@yurinakira
Have you tested not only with mods, but also without mods? That is, whether this PR has been tested to ensure that users who do not use the mod do not face any side effects.

@denverquane
The changes seem okay, but I don't have the environment to test modded AmongUs, so I can't really run and test this PR.
In the first place this change seems to go against your support policy for mods, so I'll leave it up to you to decide if you want to merge this or not. I think it would be a good way to have this proceed as a separate forked project.

@yurinakira
Copy link
Author

@kurokobo
sorry.
I tried building, but the build failed because I didn't know the .net version. So I haven't been able to test it.
I saw a similar question asked on Discord, but the answer was vague, so it seemed like they didn't provide support for the build.

@kurokobo
Copy link
Collaborator

@yurinakira
Thanks for updating, the CI uses .NET 5.0.100, and I think 5.0.x may work for local build: https://github.com/automuteus/amonguscapture/blob/master/.github/workflows/dotnet-build.yml#L22-L25

Following command builds exe file as AUCapture-WPF\bin\Release\netcoreapp3.1\publish\AUCapture-WPF.exe

dotnet publish "AUCapture-WPF\AUCapture-WPF.csproj" -p:PublishProfile=DevProfile

@yurinakira
Copy link
Author

thank you! I was able to build it!
We will test the operation with vanilla and TOHmod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants