Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add python 3.12 support #158

Merged
merged 3 commits into from
Nov 25, 2024
Merged

feat: add python 3.12 support #158

merged 3 commits into from
Nov 25, 2024

Conversation

timurcarstensen
Copy link
Member

Closes #157

@timurcarstensen timurcarstensen linked an issue Nov 25, 2024 that may be closed by this pull request
add 3.12 support #157
Closed
@timurcarstensen
Copy link
Member Author

The tests are failing until a new ifBO release is created

eddiebergman
eddiebergman reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, did you check 3.13?

Otherwise looks good. Make sure to do a look for 3.10 310 and py310 to find instances where versions are mentioned and update accordingly.

@timurcarstensen
Copy link
Member Author

While you're at it, did you check 3.13?

Otherwise looks good. Make sure to do a look for 3.10 310 and py310 to find instances where versions are mentioned and update accordingly.

  • checked 3.13, still waiting for the torch 2.6 support for that to work
  • already checked and updated/added 3.12 version everywhere :)

@timurcarstensen timurcarstensen merged commit ebe5ff5 into master Nov 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiebergman eddiebergman eddiebergman left review comments

Assignees
No one assigned
Labels
None yet
Projects
NePS Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add 3.12 support
2 participants
@timurcarstensen @eddiebergman