Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed priorband_template.py example #154

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fixed priorband_template.py example #154

merged 2 commits into from
Nov 14, 2024

Conversation

gopaljigaur
Copy link
Collaborator

This pull request includes several changes to improve error handling and parameter validation in the package. The most important changes include adding more informative error messages and ensuring parameter bounds are correctly validated.

Error Handling Improvements:

Parameter Validation:

@gopaljigaur
Copy link
Collaborator Author

This pull request includes several changes to improve the handling of fidelity parameters and validation of YAML configurations. The most important changes involve adding validation checks, updating test configurations, and modifying default values.

Validation Improvements:

  • Added a detailed assertion message for the fidelity parameter in __init__ method of neps/optimizers/multi_fidelity/successive_halving.py.
  • Introduced a check to raise a ValueError if fidelity parameter bounds are less than or equal to zero in neps/search_spaces/hyperparameters/numerical.py.

Configuration Updates:

  • Updated lower bound for wd parameter in neps_examples/template/priorband_template.py from 0 to 1e-5.
  • Changed lower bound for param_int1 in tests/test_yaml_search_space/correct_config.yaml and tests/test_yaml_search_space/correct_config_including_types.yaml from -3 to 3. [1] [2]

Test Enhancements:

  • Added a new test case test_incorrect_fidelity_parameter_bounds to validate fidelity parameter bounds in tests/test_yaml_search_space/test_search_space.py.
  • Updated test configuration files to include new parameter bounds and types in tests/test_yaml_search_space/incorrect_fidelity_bounds_config.yaml.

@gopaljigaur
Copy link
Collaborator Author

@DaStoll @eddiebergman

@DaStoll DaStoll merged commit 43617c7 into master Nov 14, 2024
7 checks passed
@gopaljigaur gopaljigaur deleted the fix-bounds branch November 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants