-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ifbo #115
Add ifbo #115
Conversation
@eddiebergman @TarekAbouChakra is the tblogging supported currently? |
Just fyi, |
As for the PR about python dependancies, just get ifbo in first and we can do the python dep thing after |
Regarding |
Think I found the issue: This line: neps/neps/plot/tensorboard_eval.py Lines 316 to 317 in 0025d3d
Basically it only initializes once, where intialization is in charge of deciding where to write to: neps/neps/plot/tensorboard_eval.py Lines 109 to 135 in 0025d3d
|
@eddiebergman how should we go about this PR? Parallelization works and I happy for now with local testing. Tblogger is the biggest bummer here, along with test cases failing. |
Just highlighting the tests passed at this point, working on rebase on the changes from @timurcarstensen from #140 |
b560734
to
f06b8dc
Compare
…d back `from typing_extensions import ...` for py310 compatability
f06b8dc
to
b65143f
Compare
Rebased onto most recent main branch |
Just a note, I went a bit more aggresive and just deleted the DyHPO code altogether, rather than commenting it out. The history for it exists in github and in general, I've never seen the commented code "uncommented" at any point and it just becomes noise. |
Added caching so we don't reload the model as often and reduce the number of warnings. Otherwise, @Neeratyoy I think it ready to go. The only thing I would ask you to check is if the tensorboard issue is resolved. I didn't know how to test it since I've never really used the feature, nor know how to activate it |
@eddiebergman I checked the example and it looks fine. With parallel workers too. Also, the Tensorboard feature looks good, as in, it works. However, there are improvements to the logging generally which I would classify as feature enhancements/fixes to the tblogger and would not block this PR for it. Looks good to be merged 👍🏽. FYI @TarekAbouChakra. |
Adding
ifBO
and refactoring a bunch of freeze-thaw based multi-fidelity algorithms.Working example here.
Existing issues or concerns:
Need resolving some issuesconfig_0_0
has the tbevent files