fix(runtime): explicitly load previous results #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test by rerunning the reproducible examples (Many thanks @danrgll!)
The issue was from my previous re-working runtime, where I forgot to ensure that if there was a trial (i.e.
config_1_1
) that relied on a previous trial (config_1_0
), to ensure that it was loaded into that cache beforeconfig_1_1
was loaded in. Main fix was just to sort accordingly and then process each one 1-by-1.PR also attempts to simplify things a bit and reduce some duplication, as fixing this issue would have introduced a lot of spaghetti.