Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how docker run args are built #267

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Change how docker run args are built #267

wants to merge 2 commits into from

Conversation

cg2v
Copy link
Member

@cg2v cg2v commented Dec 13, 2024

There are 2 changes here

  • Redoes distDocker:runJob to look more like localDocker:runJob. I did this so I could stop maintaining a patch that manually inserts a --memory switch in distDocker
  • makes localDocker's runJob use list.append instead of + to build up the list. When I copied the code, I wanted to make it more pythonic

This isn't tested yet. I'll try to do that by next tuesday or so.

@cg2v
build docker args with list.append
ce87fcf 
instead of constructing new list objects every time the list has items
appended to it, use python's list mutator functions (append and extend)
@cg2v
Build docker run args the same in distDocker
bff657d 
Make distDocker's runJob similar to localDocker's. Build a list
of args instead of assembling nested strings. Make sure to preserve
quoting of interior arguments. This has the effect of making the vm core
and memory limits effective for distDocker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cg2v