Handle locale for MaterialX inputs #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! fix build break
Also add githash on generated files
e.g. given a node def e.g. ND_standard_surface_surfaceshader will
generate a standard_surface.json and standard_surface.hpp
The hpp/json can be used for simple reflection instead of parsing mtlx libraries
Move utility python script into contrib
ashwinbhat
force-pushed
the
adsk_contrib/locale_utf8
branch
from
8032b13 to
95a0994
Compare
|
@bernardkwok I'm unsure why the build tests fail. I'm unable to repro this locally |
bernardkwok
reviewed
May 4, 2021
|
|
||
| def main(): | ||
| parser = argparse.ArgumentParser( | ||
| description="MaterialX nodedef to json/hpp convert.") |
There was a problem hiding this comment.
Nitpick. "converter" instead of "convert" ?
| return None | ||
| for elem in elemlist: | ||
| if elem.isA(mx.NodeDef) and elem.getName() == nodedefname: | ||
| #print (elem) |
| parser.add_argument(dest="inputFilename", | ||
| help="Filename of the input document.") | ||
| parser.add_argument("--node", dest="nodedef", type=str, | ||
| default="ND_standard_surface_surfaceshader", |
There was a problem hiding this comment.
Maybe leave the default to be empty string instead ?
| if elem.isA(mx.NodeDef): | ||
| jsonfilename = elem.getNodeString()+'.json' | ||
| hppfilename = elem.getNodeString()+'.hpp' | ||
| export_json(elem, jsonfilename) |
There was a problem hiding this comment.
Should we catch exceptions here in case the files cannot be written.
| \n{nodename}\nSHA1:{filehash}\nVersion:{version}\n*/\n"\ | ||
| .format(nodename=elem, filehash=INPUTFILEHASH, version=mx.getVersionString()) | ||
| variable_defs = "" | ||
| for inp in elem.getActiveInputs(): |
There was a problem hiding this comment.
As mentioned in chat, would you want to export outputs as well ?
In which case would it be better to get "value elements" instead of just inputs. ?
bernardkwok
approved these changes
May 5, 2021
ashwinbhat
changed the title
bernardkwok
pushed a commit
that referenced
this pull request
May 31, 2021
For MaterialX let's assume we have a xml with `<input name="diffColor" type="vector3" value="1,1.5,2.0"/>` mx:Vector3(1,1.5,2.0) should be interpreted as float[3] = [1.0f, 1.5f, 2.0f]. But based on the locale settings, 1,1.5 will be parsed as a value. By setting the locale on std::stringstream we ensure that input values are correctly read Some background reference around this https://stdcxx.apache.org/doc/stdlibug/24-3.html https://docs.microsoft.com/en-us/globalization/locale/number-formatting Partially addresses Issue #1183 Other changes: Basic utility to generate a json and hpp export from MaterialX nodedef e.g. given a node def e.g. ND_standard_surface_surfaceshader will generate a standard_surface.json and standard_surface.hpp The hpp/json can be used for simple reflection instead of parsing mtlx libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some background reference around this https://stdcxx.apache.org/doc/stdlibug/24-3.html
https://docs.microsoft.com/en-us/globalization/locale/number-formatting
For MaterialX let's assume we have a xml with
<input name="diffColor" type="vector3" value="1,1.5,2.0"/>mx:Vector3(1,1.5,2.0) should be interpreted as float[3] = [1.0f, 1.5f, 2.0f]
But based on the locale settings,
1,1.5will be parsed as a value.#1183