Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/totp for signup #436

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

scaletech-milan
Copy link
Contributor

What does this PR do?

  • Added the Signup for TOTP while MFA is enabled.
  • Created test cases for email verification and Totp signup.

Which issue(s) does this PR fix?

#418

If this PR affects any API reference documentation, please share the updated endpoint references

Copy link
Contributor

@lakhansamani lakhansamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change required

log.Debug("totp service not enabled: ", err)
}

isMailOTPDisabled, err := memorystore.Provider.GetBoolStoreEnvVariable(constants.EnvKeyDisableMailOTPLogin)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is not required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

- Remove redundant mail otp check
@lakhansamani lakhansamani merged commit 27b51ad into authorizerdev:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants