Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple sso provider of same type #4970

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Support multiple sso provider of same type #4970

merged 6 commits into from
Jan 9, 2025

Conversation

tung2744
Copy link
Contributor

@tung2744 tung2744 commented Jan 8, 2025

ref DEV-2407
Screenshot 2025-01-08 at 8 27 55 PM

@louischan-oursky
Copy link
Collaborator

When I test this, it seems that it is buggy when I try to edit alias

  1. Click new facebook.
  2. Focus alias, try to edit, see I cannot edit
  3. Click save.
  4. Inspect the network log, see it generates a a lot incorrect config
SCR-20250109-kgmv

louischan-oursky
louischan-oursky requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@louischan-oursky louischan-oursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4970 (comment)

@tung2744
Copy link
Contributor Author

tung2744 commented Jan 9, 2025

Added a commit to fix the bug, thanks!

@louischan-oursky louischan-oursky self-requested a review January 9, 2025 09:37
@louischan-oursky louischan-oursky merged commit a73e538 into authgear:main Jan 9, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louischan-oursky louischan-oursky louischan-oursky approved these changes

Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tung2744 @louischan-oursky