Implement settings profile pages #4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not used by me actually. Must be a false positive
It is not used by me actually. Must be a false positive
In old implementation on timezone picker, I was using json serialization. However, I changed to other approach later
1. Add cursor pointer to radio item 2. Fix gender display raw value in profile page
cychiuae
force-pushed
the
authui-v2-settings-profile
branch
from
95556a0 to
3bb09a1
Compare
cychiuae
force-pushed
the
authui-v2-settings-profile
branch
from
3bb09a1 to
645959e
Compare
louischan-oursky
requested changes
Sep 6, 2024
| .settings-user-profile-pic__edit-button { | ||
| @apply inline-flex items-center justify-center; | ||
| @apply w-9 h-9; | ||
| @apply absolute bottom-0 -right-2 tablet:right-3.5; |
There was a problem hiding this comment.
ltr trl
- This is stated in the guideline. UI v2 coding guidelines #3626
- I want a stylelint rule to warn you guys automatically about this.
| "v2.page.settings-profile-edit-gender.default.gender-label-female": "Female", | ||
| "v2.page.settings-profile-edit-gender.default.gender-label-male": "Male", | ||
| "v2.page.settings-profile-edit-gender.default.gender-label-unspecified": "Not provided", | ||
| "v2.page.settings-profile-edit-gender.default.title-gender": "Gender", |
There was a problem hiding this comment.
I guess this is page title? Then just .title, not .title-gender.
cychiuae
commented
Sep 6, 2024
| font-size: var(--navbar__item-icon-font-size); | ||
| &::before { | ||
| /* arrow_back_ios (<) in ltr and arrow_forward_ios (>) in rtl */ | ||
| @apply ltr:content-['arrow\_back\_ios'] rtl:content-['arrow\_forward\_ios']; |
When the gender is custom, it is shown as Not Provided. 
The date input handle is not shown. The end-user has no clue that the widget can be expanded by clicking at the far right. 
The icon is 32x24. This does not work when the layout is rtl. I think the icon should be 24x24, and we apply gap 8px |
louischan-oursky
requested changes
Sep 6, 2024
| @@ -1,7 +1,13 @@ | |||
| @layer components { | |||
| :root { | |||
| --date-input--calendar-icon-filter:; | |||
There was a problem hiding this comment.
: initial or : unset? Empty seems weird.
maybe more readable?
louischan-oursky
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-1832
ref DEV-1833
ref DEV-1834
ref DEV-1835
ref DEV-1836
ref DEV-1837
ref DEV-1838
ref DEV-1839