Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Vite as JS bundler for AuthUI #4691

Merged
merged 20 commits into from
Sep 5, 2024
Merged

Switch to Vite as JS bundler for AuthUI #4691

merged 20 commits into from
Sep 5, 2024

Conversation

andychow326
Copy link
Contributor

ref DEV-1978

@andychow326 andychow326 force-pushed the 1978-vite-authui branch 2 times, most recently from d01e5a7 to f5d317b Compare September 3, 2024 11:51
@andychow326 andychow326 changed the title WIP: Switch to Vite as JS bundler for AuthUI Switch to Vite as JS bundler for AuthUI Sep 3, 2024
@andychow326 andychow326 changed the title Switch to Vite as JS bundler for AuthUI WIP: Switch to Vite as JS bundler for AuthUI Sep 3, 2024
@andychow326 andychow326 force-pushed the 1978-vite-authui branch 5 times, most recently from 47d7859 to 89ee13c Compare September 3, 2024 15:46
@louischan-oursky louischan-oursky self-requested a review September 4, 2024 04:07
louischan-oursky
louischan-oursky requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@louischan-oursky louischan-oursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We must ensure the build is deterministic. How can we ensure this in CI? We can borrow React Strict mode. We intentionally build twice, and compare if the two builds are reproducible (or deterministic).

Makefile Outdated Show resolved Hide resolved
@andychow326 andychow326 force-pushed the 1978-vite-authui branch 4 times, most recently from 4550e06 to 504d292 Compare September 4, 2024 11:53
@andychow326 andychow326 changed the title WIP: Switch to Vite as JS bundler for AuthUI Switch to Vite as JS bundler for AuthUI Sep 4, 2024
louischan-oursky
louischan-oursky requested changes Sep 5, 2024
View reviewed changes
authui/src/imagepicker.ts Outdated Show resolved Hide resolved
authui/check-bundle-consistency.sh Outdated Show resolved Hide resolved
authui/check-bundle-consistency.sh Outdated Show resolved Hide resolved
@louischan-oursky louischan-oursky self-assigned this Sep 5, 2024
@louischan-oursky louischan-oursky mentioned this pull request Sep 5, 2024
Closed
@louischan-oursky louischan-oursky merged commit fedb195 into authgear:main Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louischan-oursky louischan-oursky louischan-oursky approved these changes

Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andychow326 @louischan-oursky