-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify LDAP support #4485
Open
louischan-oursky
wants to merge
10
commits into
authgear:main
Choose a base branch
from
louischan-oursky:dev-1578-specify-ldap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Specify LDAP support #4485
louischan-oursky
wants to merge
10
commits into
authgear:main
from
louischan-oursky:dev-1578-specify-ldap
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungc-io
reviewed
Jul 22, 2024
louischan-oursky
force-pushed
the
dev-1578-specify-ldap
branch
from
July 22, 2024 16:39
27cae7c
to
29ea3f9
Compare
cychiuae
reviewed
Jul 23, 2024
louischan-oursky
force-pushed
the
dev-1578-specify-ldap
branch
from
July 27, 2024 02:30
29ea3f9
to
00b1c60
Compare
cychiuae
reviewed
Jul 29, 2024
cychiuae
reviewed
Jul 29, 2024
louischan-oursky
force-pushed
the
dev-1578-specify-ldap
branch
from
July 31, 2024 10:51
00b1c60
to
d655278
Compare
base_distinguished_name: "dc=mycompany,dc=com" | ||
relative_distinguished_name_attribute: "uid" | ||
base_dn: "dc=localhost" | ||
search_filter_template: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a section to document how the developer configure for their use case. Like if he wants to enter email and password to sign in, how to configure.
It turns out the LDAP server does not return oid in the search request.
louischan-oursky
force-pushed
the
dev-1578-specify-ldap
branch
from
August 6, 2024 05:16
6fab5e9
to
1b99e08
Compare
@yyorkchan @cychiuae I have added two commits to update the spec.
|
yyorkchan
reviewed
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-1578
Tag @cychiuae @yyorkchan