Add createAuthenticator mutation #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var authenticatorDef = graphql.NewInputObject(graphql.InputObjectConfig{ | ||
| Name: "IdentityDefinition", | ||
| Description: "Definition of an identity. This is a union object, exactly one of the available fields must be present.", |
There was a problem hiding this comment.
an authenticator, not an identity.
| }, | ||
| "definition": &graphql.InputObjectFieldConfig{ | ||
| Type: graphql.NewNonNull(authenticatorDef), | ||
| Description: "Definition of the new identity.", |
There was a problem hiding this comment.
the new authenticator.
| @@ -1,1675 +0,0 @@ | |||
| """""" | |||
There was a problem hiding this comment.
Do not delete this file in this commit.
|
|
||
| """Password authenticator definition.""" | ||
| password: AuthenticatorDefinitionPassword | ||
| } |
There was a problem hiding this comment.
I prefer the following shape. What do you think?
input AuthenticatorDefinition {
kind: AuthenticatorKind!
"""We will check type, and determine which field we will then look at."""
type: AuthenticatorType!
oobOtpEmail: AuthenticatorDefinitionOOBOTPEmail
oobOtpSMS: AuthenticatorDefinitionOOBOTPSMS
password: AuthenticatorDefinitionPassword
}
input AuthenticatorDefinitionOOBOTPEmail {
email: String!
}
input AuthenticatorDefinitionOOBOTPSMS {
phone: String!
}
input AuthenticatorDefinitionPassword {
password: String!
}
|
@louischan-oursky Updated, thanks! |
louischan-oursky
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-1360