Allow overrideMaxTrial on internalGeneratePasswordWithSource

authgear · Aug 28, 2024 · b675e0d · b675e0d
1 parent c63e644
commit b675e0d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/portal/src/util/passwordGenerator.test.ts b/portal/src/util/passwordGenerator.test.ts
@@ -98,13 +98,14 @@ describe("passwordGenerator", () => {
         },
       };
     };
-
+    const OVERRIDE_MAX_TRIAL = 25; // ref PR#4666
     const [password, attempts] = internalGeneratePasswordWithSource(
       createRandSource(),
       {
         digit_required: true,
         excluded_keywords: ["0"],
-      }
+      },
+      OVERRIDE_MAX_TRIAL
     );
     expect(password).not.toBeNull();
     expect(password).not.toContain("0");

diff --git a/portal/src/util/passwordGenerator.ts b/portal/src/util/passwordGenerator.ts
@@ -18,7 +18,7 @@ const AllCharLists = [
   CharListSymbol,
 ];
 
-const MaxTrials = 25;
+const MaxTrials = 10;
 const DefaultMinLength = 8;
 const GuessableEnabledMinLength = 32;
 
@@ -74,9 +74,11 @@ export function generatePasswordWithSource(
 
 export function internalGeneratePasswordWithSource(
   source: RandSource,
-  policy: PasswordPolicyConfig
+  policy: PasswordPolicyConfig,
+  overrideMaxTrials?: number
 ): [string | null, number] {
-  for (let i = 0; i < MaxTrials; i++) {
+  const maxTrials = overrideMaxTrials ?? MaxTrials;
+  for (let i = 0; i < maxTrials; i++) {
     const password = generatePasswordOnce(source, policy);
     if (password !== null) {
       return [password, i];