Skip to content

Commit

Permalink
Add some comments to explain what is happening in validateFeatureConfig
Browse files Browse the repository at this point in the history
  • Loading branch information
tung2744 committed Dec 6, 2024
1 parent 0d2a4e9 commit aafca26
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/lib/config/configsource/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ func (d AuthgearYAMLDescriptor) validateFeatureConfig(validationCtx *validation.
if incomingFCError == nil || !ok {
return incomingFCError
}
// https://github.com/authgear/authgear-server/commit/888e57b4b6fa9de7cd5786111cdc5cc244a85ac0
// If the original config has some feature config error, we allow the user
// to save the config without correcting them. This is for the case that
// the app is downgraded from a higher plan.
originalFCError := d.validateBasedOnFeatureConfig(original, fc)
originalAggregatedError, ok := originalFCError.(*validation.AggregatedError)
if originalFCError == nil || !ok {
Expand Down

0 comments on commit aafca26

Please sign in to comment.