Skip to content

Commit

Permalink
Soft remove SIWE #4924
Browse files Browse the repository at this point in the history
ref DEV-2300
  • Loading branch information
tung2744 authored Dec 9, 2024
2 parents c582f61 + 6a617fe commit a36ee3d
Show file tree
Hide file tree
Showing 147 changed files with 3,684 additions and 15,493 deletions.
2 changes: 0 additions & 2 deletions .make-lint-expect
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ pkg/api/apierrors/tags.go cannot import github.com/authgear/authgear-server/pkg/
pkg/api/event/blocking/util.go cannot import github.com/authgear/authgear-server/pkg/util/accesscontrol
pkg/api/event/event.go cannot import github.com/authgear/authgear-server/pkg/util/accesscontrol
pkg/api/event/hook_response.go cannot import github.com/authgear/authgear-server/pkg/util/validation
pkg/api/model/siwe.go cannot import github.com/authgear/authgear-server/pkg/util/web3
pkg/api/model/web3.go cannot import github.com/authgear/authgear-server/pkg/util/web3

exit status 1
pkg/lib/deps/deps_common.go cannot import github.com/authgear/authgear-server/pkg/auth/handler/webapp/authflowv2
Expand Down
2 changes: 0 additions & 2 deletions .vettedpositions
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
/pkg/auth/handler/saml/login.go:296:3: requestcontext
/pkg/auth/handler/saml/login_finish.go:41:9: requestcontext
/pkg/auth/handler/saml/logout.go:86:9: requestcontext
/pkg/auth/handler/siwe/nonce.go:46:38: requestcontext
/pkg/auth/handler/webapp/account_status.go:48:27: requestcontext
/pkg/auth/handler/webapp/auth_entry_point_middleware.go:31:31: requestcontext
/pkg/auth/handler/webapp/auth_entry_point_middleware.go:32:35: requestcontext
Expand Down Expand Up @@ -172,7 +171,6 @@
/pkg/auth/handler/webapp/login.go:115:28: requestcontext
/pkg/auth/handler/webapp/login_link_otp.go:121:27: requestcontext
/pkg/auth/handler/webapp/logout.go:71:27: requestcontext
/pkg/auth/handler/webapp/missing_web3_wallet.go:78:27: requestcontext
/pkg/auth/handler/webapp/panic_middleware.go:68:61: requestcontext
/pkg/auth/handler/webapp/passkey_creation_options.go:43:28: requestcontext
/pkg/auth/handler/webapp/passkey_request_options.go:52:28: requestcontext
Expand Down
9 changes: 3 additions & 6 deletions authui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ make generate-material-icons

After that, commit the changes in `scripts/python/material-icons.txt`, `authui/src/authflowv2/icons/material-symbols-outlined-subset.ttf` and `authui/src/authflowv2/icons/material-symbols-outlined-subset.woff2`.

### @metamask/jazzicon
### ./tarballs/

In oursky/authgear-server, the connection to the URL `https://codeload.github.com/MetaMask/jazzicon/tar.gz/4fe23bbbe5088e128cb24082972e28d87e76d156` fails very often.
Therefore, we download the tarball, and use it directly.
We also updated to the latest commit.
See https://github.com/MetaMask/jazzicon/compare/d923914fda6a8795f74c2e66134f73cd72070667..4fe23bbbe5088e128cb24082972e28d87e76d156 for the changes.
The changes DO NOT cover runtime behavior changes, so it is safe to upgrade.
As a workaround, we can put tarballs in ./tarballs to install dependency from a tarball.
This usage is not encouraged.
182 changes: 2 additions & 180 deletions authui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 1 addition & 8 deletions authui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@
"process": false
},
"overrides": {
"caniuse-lite": "1.0.30001653",
"ethers": {
"ws": "^7.5.10"
}
"caniuse-lite": "1.0.30001653"
},
"devDependencies": {
"@jest/globals": "29.7.0",
Expand Down Expand Up @@ -57,18 +54,14 @@
"@floating-ui/dom": "1.5.4",
"@hotwired/stimulus": "3.2.2",
"@hotwired/turbo": "7.3.0",
"@metamask/detect-provider": "2.0.0",
"@metamask/jazzicon": "file:tarballs/jazzicon-4fe23bbbe5088e128cb24082972e28d87e76d156.tar.gz",
"@sentry/browser": "^8.33.1",
"@tabler/icons": "1.107.0",
"axios": "1.7.4",
"cldr-localenames-full": "44.1.0",
"cropperjs": "1.6.1",
"ethers": "6.13.2",
"intl-tel-input": "18.5.3",
"libphonenumber-js": "1.10.53",
"luxon": "3.4.4",
"siwe": "2.3.2",
"zxcvbn": "4.4.2"
}
}
4 changes: 0 additions & 4 deletions authui/src/authgear.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import {
PasskeyAutofillController,
AuthflowPasskeyErrorController,
} from "./passkey";
import { WalletConfirmationController, WalletIconController } from "./web3";
import { init as SentryInit, browserTracingIntegration } from "@sentry/browser";
import { LockoutController } from "./lockout";
import { MirrorButtonController } from "./mirrorbutton";
Expand Down Expand Up @@ -118,9 +117,6 @@ Stimulus.register(
);
Stimulus.register("authflow-passkey-error", AuthflowPasskeyErrorController);

Stimulus.register("web3-wallet-confirmation", WalletConfirmationController);
Stimulus.register("web3-wallet-icon", WalletIconController);

Stimulus.register("lockout", LockoutController);

Stimulus.register("mirror-button", MirrorButtonController);
Loading

0 comments on commit a36ee3d

Please sign in to comment.