Further reduce noise #4205

ref DEV-1251

pkg/api/apierrors/skip_logging.go

@@ -3,9 +3,9 @@ package apierrors
 import (
 	"context"
 	"database/sql"
+	"encoding/json"
 	"errors"
 	"net/http"
-	"syscall"
 
 	"github.com/lib/pq"
 	"github.com/sirupsen/logrus"
@@ -53,6 +53,13 @@ func IgnoreError(err error) (ignore bool) {
 		ignore = true
 	}
 
+	// json.Unmarshal returns a SyntaxError if the JSON can't be parsed.
+	// https://pkg.go.dev/encoding/json#SyntaxError
+	var jsonSyntaxError *json.SyntaxError
+	if errors.As(err, &jsonSyntaxError) {
+		ignore = true
+	}
+
 	var pqError *pq.Error
 	if errors.As(err, &pqError) {
 		// https://www.postgresql.org/docs/13/errcodes-appendix.html
@@ -62,11 +69,6 @@ func IgnoreError(err error) (ignore bool) {
 		}
 	}
 
-	if errors.Is(err, syscall.EPIPE) {
-		// syscall.EPIPE is "write: broken pipe"
-		ignore = true
-	}
-
 	if errors.Is(err, sql.ErrTxDone) {
 		// The sql package will rollback the transaction when the context is canceled.
 		// https://pkg.go.dev/database/sql/driver#ConnBeginTx

pkg/api/apierrors/skip_logging_test.go

@@ -2,11 +2,15 @@ package apierrors
 
 import (
 	"context"
+	"database/sql"
+	"encoding/json"
 	"fmt"
+	"net/http"
+	"syscall"
 	"testing"
 
+	"github.com/lib/pq"
 	"github.com/sirupsen/logrus"
-
 	. "github.com/smartystreets/goconvey/convey"
 
 	"github.com/authgear/authgear-server/pkg/util/log"
@@ -38,7 +42,54 @@ func TestSkipLogging(t *testing.T) {
 			So(myhook.IsSkipped, ShouldBeTrue)
 		})
 
-		Convey("Ignore entry with wrapped context.Canceled error", func() {
+		Convey("Ignore entry with context.DeadlineExceeded error", func() {
+			logger.WithError(context.DeadlineExceeded).Error("error")
+			So(myhook.IsSkipped, ShouldBeTrue)
+		})
+
+		Convey("Ignore entry with http.ErrAbortHandler error", func() {
+			logger.WithError(http.ErrAbortHandler).Error("error")
+			So(myhook.IsSkipped, ShouldBeTrue)
+		})
+
+		Convey("Ignore json.SyntaxError", func() {
+			var anything interface{}
+			err := json.Unmarshal([]byte("{"), &anything)
+			So(err, ShouldBeError, "unexpected end of JSON input")
+
+			logger.WithError(err).Error("error")
+			So(myhook.IsSkipped, ShouldBeTrue)
+		})
+
+		Convey("Ignore pg.Error.Code 57014", func() {
+			err := &pq.Error{
+				Code: "57014",
+			}
+
+			logger.WithError(err).Error("error")
+			So(myhook.IsSkipped, ShouldBeTrue)
+		})
+
+		Convey("Do not ignore syscall.EPIPE", func() {
+			err := syscall.EPIPE
+			logger.WithError(err).Error("error")
+			So(err, ShouldBeError, "broken pipe")
+			So(myhook.IsSkipped, ShouldBeFalse)
+		})
+
+		Convey("Do not ignore syscall.ECONNREFUSED", func() {
+			err := syscall.ECONNREFUSED
+			logger.WithError(err).Error("error")
+			So(err, ShouldBeError, "connection refused")
+			So(myhook.IsSkipped, ShouldBeFalse)
+		})
+
+		Convey("Ignore sql.ErrTxDone error", func() {
+			logger.WithError(sql.ErrTxDone).Error("error")
+			So(myhook.IsSkipped, ShouldBeTrue)
+		})
+
+		Convey("Ignore entry with wrapped error", func() {
 			logger.WithError(fmt.Errorf("wrap: %w", context.Canceled)).Error("error")
 			So(myhook.IsSkipped, ShouldBeTrue)
 		})