Stop using otelhttp due to memory leak #4922

#4922
authgear · Dec 5, 2024 · 45d5dc0 · 45d5dc0
2 parents ced3a3f + 53da128
commit 45d5dc0
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/pkg/util/httproute/httprouteotel/httprouteotel.go b/pkg/util/httproute/httprouteotel/httprouteotel.go
@@ -19,10 +19,15 @@ type OTelRouter struct {
 	router Router
 }
 
-func NewOTelRouter(router Router) *OTelRouter {
-	return &OTelRouter{
-		router: router,
-	}
+func NewOTelRouter(router Router) Router {
+	// It is observed that otelhttp >=v0.56 <=v0.57 has memory leak that
+	// causing memory usage increase over time.
+	// See https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6315
+	// So let's stop using it.
+	// return &OTelRouter{
+	// 	router: router,
+	// }
+	return router
 }
 
 func (r *OTelRouter) wrapHandler(route httproute.Route, h http.Handler) http.Handler {