Replace RestClient with Faraday #592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorton
force-pushed
the
faraday
branch
2 times, most recently
from
cc59bb7 to
c52a279
Compare
|
@arpit-jn sorry for pinging you, but you're the last person to commit to master. Any chance this PR can be reviewed/merged? If this isn't relevant I'd like to consider other options than to keep rebasing this branch. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
Auth0::HttpClientas a shim/interface for the HTTP Client library in use. This kept the changes to existing specs to a minimum.Replaced RestClient with Faraday as the underlying HTTP library.
References
See #483
Testing
Existing tests have been refactored. Will need to integration test the gem against dependent projects.
Checklist