Update dependencies used for running tests #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update chai and mocha to the latest versions and update nyc to the latest version that supports Node 4.
ziluvatar
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update chai to 4.1.2 and mocha to the latest versions and update nyc to the latest version that supports Node 4.
Motivation
I keep hitting minor differences with
chai@1, with the documentation forchai@4. There are also numerous bug fixes and additions that we are missing out with this library. The only breaking change as it relates to this code base is the removal of the "lint" friendly assertions inchai@2.Mocha@2had a "fuzzy" version of the.onlyfunction that made running individual tests almost impossible without artificially changing the description (i.e.describe.only('xxxx expires' //....). There are no breaking changes that should affect the project.