support timeout option in Popup.loginWithCredentials (#1273)

* support timeout option in Popup.loginWithCredentials * add tests for popup+timeout
auth0 · Oct 28, 2022 · 60563bc · 60563bc
1 parent 093bc72
commit 60563bc
Show file tree

Hide file tree

Showing 2 changed files with 207 additions and 149 deletions.
diff --git a/src/web-auth/popup.js b/src/web-auth/popup.js
@@ -252,12 +252,19 @@ Popup.prototype.authorize = function(options, cb) {
  * @param {credentialsCallback} cb
  * @memberof Popup.prototype
  */
-Popup.prototype.loginWithCredentials = function(options, cb) {
+Popup.prototype.loginWithCredentials = function (options, cb) {
   options.realm = options.realm || options.connection;
   options.popup = true;
   options = objectHelper
-    .merge(this.baseOptions, ['redirectUri', 'responseType', 'state', 'nonce'])
+    .merge(this.baseOptions, [
+      'redirectUri',
+      'responseType',
+      'state',
+      'nonce',
+      'timeout'
+    ])
     .with(objectHelper.blacklist(options, ['popupHandler', 'connection']));
+
   options = this.transactionManager.process(options);
   this.crossOriginAuthentication.login(options, cb);
 };