Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkpoint pagination to get all organizations #984

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

iwakrur
Copy link
Contributor

@iwakrur iwakrur commented Nov 20, 2024

🔧 Changes

This updates the way to get all organizations. It enables to export more than 1000 organizations by using checkpoint pagination.

📚 References

related changes

🔬 Testing

related existing test

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • (N/A) I have added documentation for all new/changed functionality (or N/A)

@iwakrur iwakrur requested a review from a team as a code owner November 20, 2024 09:25
@iwakrur iwakrur marked this pull request as draft November 22, 2024 01:58
@kushalshit27
Copy link
Contributor

kushalshit27 commented Nov 24, 2024

Hi, @tc3-iwakura
Thank you for submitting this PR! I appreciate the time and effort you put into it and your approach to tackling this issue. The code looks good overall.

I will check the failing E2E test and merge it soon. Thanks again.

testdata (remove create my-rule)
@kushalshit27
Copy link
Contributor

Hi, @tc3-iwakura
I have updated the recordings on tc3-japan#1
Please merge it to update this PR

fix e2e recordings for Use checkpoint pagination to get all organizations
@iwakrur
Copy link
Contributor Author

iwakrur commented Nov 24, 2024

Hi, @kushalshit27 .
Thank you for updating recordings.
I found lockdown e2e test will be successful if add AUTH0_E2E_CLIENT_ID=Vp0gMRF8PtMzekil38qWoj4Fjw2VjRZE to the below CI command, but it may be better to add the key-value to Circle CI environment.
Could you please tell me which is better or another way?

- run: AUTH0_HTTP_RECORDINGS="lockdown" npm run test:e2e:node-module

related code

@kushalshit27 kushalshit27 merged commit 5ff0727 into auth0:master Nov 25, 2024
6 of 7 checks passed
@kushalshit27
Copy link
Contributor

Hi, @tc3-iwakura
We will release it soon, along with other items, by the end of this week.

Thank you again for submitting this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants