Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Form, Flow and Flow Vault Connection #982

Merged
merged 19 commits into from
Nov 18, 2024

Conversation

kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Nov 15, 2024

🔧 Changes

Add support for Form, Flow and Flow Vault Connection

forms:
  - name: New Kyc form
    body: ./forms/New Kyc form.json
flows:
  - name: Update KYC Name
    body: ./flows/Update KYC Name.json
flowVaultConnections:
  - name: 'Auth0 M2M Con #1'
    app_id: AUTH0
    ready: true
  - name: 'New Auth0 M2M Con #2'
    app_id: AUTH0
    setup: @@SETUP_CONFIG@@

⚙️ Configuration options:

"AUTH0_INCLUDED_ONLY": ["forms", "flows", "flowVaultConnections"],
"AUTH0_KEYWORD_REPLACE_MAPPINGS": {
    "SETUP_CONFIG": {
      "client_id": "<add M2M client id>",
      "client_secret": "<add M2M client_secret>",
      "domain": "<add M2M domain>",
      "type": "OAUTH_APP"
    }
}

📌 Note:

  • Flow vault connection: setup key does not support keyword preservation, export or dump commmand will not preserve setup key in local configuration file.
  • Duplicate names for Forms, Flows, and Flow Vault Connections are not allowed to ensure better organization and avoid conflicts in resource configurations.

📚 References

Resolves: #904

🔬 Testing

  • unit test added for Form, Flow and Flow Vault Connection
  • E2E test updated

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 77.55102% with 99 lines in your changes missing coverage. Please review.

Project coverage is 79.91%. Comparing base (6d2f9bc) to head (d1032d2).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/tools/auth0/handlers/flowVaultConnections.ts 79.45% 6 Missing and 9 partials ⚠️
src/context/yaml/handlers/flows.ts 72.72% 7 Missing and 5 partials ⚠️
src/context/yaml/handlers/forms.ts 72.72% 7 Missing and 5 partials ⚠️
src/context/directory/handlers/flows.ts 71.05% 6 Missing and 5 partials ⚠️
src/context/directory/handlers/forms.ts 71.05% 6 Missing and 5 partials ⚠️
src/tools/auth0/handlers/flows.ts 83.33% 4 Missing and 7 partials ⚠️
...context/directory/handlers/flowVaultConnections.ts 76.92% 5 Missing and 4 partials ⚠️
src/context/yaml/handlers/flowVaultConnections.ts 64.00% 5 Missing and 4 partials ⚠️
src/tools/auth0/handlers/forms.ts 85.18% 3 Missing and 5 partials ⚠️
src/utils.ts 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   80.18%   79.91%   -0.27%     
==========================================
  Files         113      122       +9     
  Lines        3871     4312     +441     
  Branches      768      837      +69     
==========================================
+ Hits         3104     3446     +342     
- Misses        474      523      +49     
- Partials      293      343      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalshit27 kushalshit27 marked this pull request as ready for review November 15, 2024 11:57
@kushalshit27 kushalshit27 requested a review from a team as a code owner November 15, 2024 11:57
@kushalshit27 kushalshit27 merged commit 0f84063 into master Nov 18, 2024
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-714-deploy-cli-for-forms branch November 18, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forms support
3 participants