DRAFT: Adding proxy functionality for node module usage #885
+50
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Even when a
proxy_url
is passed-in to the Deploy when used as a node module, it does not get utilized properly. This is because therun
function, the sole function responsible for setting-up the proxy, is not executed when the functions are used as a node module. This PR proposed to move the proxy configuration into thedump
anddeploy
functions themselves so that a proxy can be used by either mode of operation.📚 References
🔬 Testing
Added a placeholder E2E test for local testing. Not yet sure if this test can be run in CI for lack of dependency proxy server.
📝 Checklist