DXCDT-377: E2E test cases for keyword presevation #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T-375-rename-load-to-loadAssetsFromAuth0
…ort' into fix-make-keyword-preservation-more-flexible
willvedd
commented
Feb 23, 2023
Comment on lines
+399
to
+404
| // expect(yaml.tenant.enabled_locales).to.equal('@@LANGUAGES@@'); TODO: enable @@ARRAY@@ keyword preservation in yaml formats | ||
|
|
||
| // const emailTemplateHTML = fs | ||
| // .readFileSync(path.join(workDirectory, 'emailTemplates', 'welcome_email.html')) | ||
| // .toString(); | ||
| // expect(emailTemplateHTML).to.contain('##TENANT##'); TODO: enable keyword preservation in auxillary template files |
There was a problem hiding this comment.
This and the similar test below will be added in the coming days when the relevant fix has been added.
willvedd
commented
Feb 23, 2023
| tenant: | ||
| allowed_logout_urls: | ||
| - https://travel0.com/logoutCallback | ||
| # enabled_locales: @@LANGUAGES@@ TODO: enable @@ARRAY@@ keyword preservation in yaml |
There was a problem hiding this comment.
This also requires a fix that will come later.
Codecov ReportBase: 84.30% // Head: 84.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## fix-make-keyword-preservation-more-flexible #753 +/- ##
============================================================================
Coverage 84.30% 84.30%
============================================================================
Files 115 115
Lines 3486 3486
Branches 660 660
============================================================================
Hits 2939 2939
Misses 311 311
Partials 236 236 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Base automatically changed from
fix-make-keyword-preservation-more-flexible
to
master
February 23, 2023 19:18
sergiught
reviewed
Feb 23, 2023
sergiught
reviewed
Feb 23, 2023
test/e2e/recordings/should-preserve-keywords-for-directory-format.json
Outdated
Show resolved
Hide resolved
sergiught
reviewed
Feb 23, 2023
test/e2e/recordings/should-preserve-keywords-for-yaml-format.json
Outdated
Show resolved
Hide resolved
sergiught
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
While many unit tests were added alongside the integration of the
preserveKeywordsfunction into the export process (#751), there is still a need for E2E test cases that simulate more real scenarios. This PR adds these test cases for fuller testing coverage of the keyword preservation feature.The work done in this PR has highlighted two key pieces of functionality missing:
@@array replacement syntax in YAML files due to invalid syntax if left as-is and invalid if wrapped in quotes.Both of the above have test cases written and commented-out but will be addressed in the coming days.
📚 References
Keyword Preservation RFC: #688
Related implementation PR: #751
🔬 Testing
This PR only adds testing.
📝 Checklist