-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-378: Keyword Replacement E2E Tests #735
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7112d0f
Adding keyword replacement test for yaml and recordings
willvedd 1afec82
Adding keyword replacement test for directory and recordings
willvedd 10f7a26
Merge branch 'master' into DXCDT-378-e2e-test-keyword-replacement
willvedd 19ce9a5
Update test/e2e/testdata/keyword-replacements/yaml/tenant.yaml
willvedd 1e7ab36
Update test/e2e/testdata/keyword-replacements/yaml/_reset.yaml
willvedd df8c525
Update test/e2e/testdata/keyword-replacements/directory/tenant.json
willvedd 67ae8ce
Update test/e2e/recordings/should-deploy-directory-(JSON)-config-with…
willvedd f047415
Update test/e2e/recordings/should-deploy-yaml-config-with-keyword-rep…
willvedd d4e4338
Update test/e2e/testdata/keyword-replacements/directory/_reset.json
willvedd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was discovered during this work that the
@@
array syntax does not work for directory formats. It does work for the YAML handler though. This will need to be addressed in a follow-up PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: Actually, this is a mistake with how I did the E2E test originally and has since been fixed.