DXCDT-378: Keyword Replacement E2E Tests #735
Conversation
willvedd
changed the title
|
|
||
| const keywordMapping = { | ||
| COMPANY_NAME: 'Travel0', | ||
| //LANGUAGES: ['en', 'es'], //TODO: support array replacement for directory format |
There was a problem hiding this comment.
It was discovered during this work that the @@ array syntax does not work for directory formats. It does work for the YAML handler though. This will need to be addressed in a follow-up PR.
There was a problem hiding this comment.
Update: Actually, this is a mistake with how I did the E2E test originally and has since been fixed.
test/e2e/recordings/should-deploy-yaml-config-with-keyword-replacements.json
Outdated
Show resolved
Hide resolved
test/e2e/recordings/should-deploy-directory-(JSON)-config-with-keyword-replacements.json
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 83.60% // Head: 83.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 114 114
Lines 3379 3379
Branches 628 628
=======================================
Hits 2825 2825
Misses 324 324
Partials 230 230 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
…-keyword-replacements.json Co-authored-by: Sergiu Ghitea <[email protected]>
…lacements.json Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
🔧 Changes
As we embark on work to address #328 , it is important to not introduce any regressions with the current keyword replacement functionality. While this functionality has a decent amount of unit-testing, the coverage in our end-to-end tests are lacking. This PR introduces a baseline of testing to fill this gap.
Notably, this PR found a bug that prevents the usage of theUpdate: This was actually a mistake in the implementation of the E2E test and has been corrected in a separate commit!@@array replacement syntax with the directory format (pointed out in comment below). Which just further highlights the need for this testing.🔬 Testing
This PR only introduces testing additions.
📝 Checklist