Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exporting SAML connections base64 encode the certificate #1008

Conversation

kushalshit27
Copy link
Contributor

🔧 Changes

Fix: exporting SAML connections base 64 encode the certificate

connections:
  - name: Sample-SAML-connection
    strategy: samlp
    options:
        ......... ... .. . . . . 
+      cert: <base64 encoded>
+      signingCert: <base64 encoded>
        ......... ... .. . . . . 

📚 References

🔬 Testing

Test passed

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (6e98caa) to head (cc6b9bd).

Files with missing lines Patch % Lines
src/context/directory/handlers/connections.ts 0.00% 4 Missing and 1 partial ⚠️
src/context/yaml/handlers/connections.ts 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
- Coverage   80.34%   80.20%   -0.14%     
==========================================
  Files         125      125              
  Lines        4548     4562      +14     
  Branches      877      884       +7     
==========================================
+ Hits         3654     3659       +5     
- Misses        529      535       +6     
- Partials      365      368       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalshit27 kushalshit27 marked this pull request as ready for review January 7, 2025 09:05
@kushalshit27 kushalshit27 requested a review from a team as a code owner January 7, 2025 09:05
@kushalshit27 kushalshit27 changed the title fix: exporting SAML connections base 64 encode the certificate fix: exporting SAML connections base64 encode the certificate Jan 7, 2025
@kushalshit27 kushalshit27 merged commit 83d31b9 into master Jan 7, 2025
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-796-exporting-connections-base-64-encode-the-certificate branch January 7, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants