Implementation of new Operations #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palinko91
force-pushed
the
master
branch
2 times, most recently
from
5130930 to
42e57a4
Compare
bjorn
approved these changes
Dec 6, 2024
| pub enum HostFunctionType { | ||
| HostFunctionTypeHostFunctionTypeInvokeContract, | ||
| HostFunctionTypeHostFunctionTypeCreateContract, | ||
| HostFunctionTypeHostFunctionTypeUploadContractWasm, |
There was a problem hiding this comment.
I wondered why this was prefixed twice, but then I see it's done also at https://developers.stellar.org/docs/data/horizon/api-reference/resources/operations/object/invoke-host-function. Weird, heh.
There was a problem hiding this comment.
Would it maybe make sense to remove the prefixes through renaming? Because when referring to this enum in Rust we now would get for example HostFunctionType::HostFunctionTypeHostFunctionTypeInvokeContract...
…estoreFootprintOp Signed-off-by: palinko91 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solved problem #11 for me.
Refference ledger where I tested on mainnet: 52385298
Pretty important because I experienced errors when I subscribed to payment stream and if I didn't do unwrap_or(), just let the ? solve it then errored out because of serde. With this fix the new Operations can be handled.