Hotfix for Transient problems in parallel #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ridFunction::MakeTRef in ProblemOperators
Heinrich-BR
approved these changes
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Heinrich-BR
approved these changes
Dec 19, 2024
loganharbour
pushed a commit
to loganharbour/platypus
that referenced
this pull request
Jan 7, 2025
…exanderianblair/parallel-transient-hotfix Hotfix for Transient problems in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug seen when running transient problems in parallel where the update vector dX_dt was set to a different size than the residual vector.
_block_true_offsetsis now used consistently throughout ProblemOperators, usingGridFunction::MakeTRefto set gridfunction data from solution vectors.