Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hephaestus Dependency #5

Merged
merged 65 commits into from
Jul 11, 2024
Merged

Remove Hephaestus Dependency #5

merged 65 commits into from
Jul 11, 2024

Conversation

EdwardPalmer99
Copy link

@EdwardPalmer99 EdwardPalmer99 commented Jun 21, 2024 •
edited
Loading

Changes:

  • Hephaestus is no longer a dependency.
  • .cpp extensions changed to .C / .hpp extensions changed to .h.
  • Fixed headers and makefiles.
  • Hephaestus namespaces changed to platypus.
  • Adds some of the hephaestus unit tests.

Caveats:

  • Removes LineSampler due to issues with linking gslib.
  • Removes spdlog due to linking issues. All splog messages have been commented-out. Requires work.
  • Docker files and CSD3 build scripts updated.
  • Files merged-in from Hephaestus require name changes and formatting changes to be consistent.

@EdwardPalmer99 EdwardPalmer99 self-assigned this Jun 21, 2024
@EdwardPalmer99 EdwardPalmer99 mentioned this pull request Jun 21, 2024
Closed
@EdwardPalmer99 EdwardPalmer99 marked this pull request as ready for review June 21, 2024 14:33
Edward Palmer added 26 commits June 27, 2024 10:11
Update version.
9029d06
Removes hephaestus as a submodule from .gitmodules.
e13cb1f
Completely removees hephaestus submodule. Renames directory to hephae…
cbb01c1 
…stus_master.
Removes hephaestus clang formatting, license, readme, contributing.
66b3d48
Removes hephaestus github workflows and gitlab ci.
df21015
Removes pre-commit config.
49a76b7
Removes hephaestus gitmodules file; moves hephaestus directory from c…
3e2447f 
…ontrib.
Renames hephaestus_master back to hephaestus.
0db8e0e
Moves hephaestus files into include/src directories. Fails to compile…
f4e893b 
… successfully.
Changes ".hpp" extensions to ".h"/
be0edee
Fixes includes, removes spdlog dependency.
1f0f634
Updates module options in makefile.
92373b8
Fixes and simplifies platypus.mk.
8423fd0
Moves hephaestus header into base directory.
5dc903a
Changes source file extensions from .c to .C
bafcbb5
Disable Werror=reorder.
797381d
Removes the line sampler to avoid gslib linking issues.
ed94f9b
Changes extension to .C
fbd9f59
Reorders parameters to fix some of the compiler errors.
76aa5de
Fixes all Werror=reorder errors.
807ea5e
Updated dockerfiles.
d8935aa
Removes gslib dependency.
a27b5ed
Renames hephaestus namespace to platypus.
d65ac55
Update cclake build script.
6f314f5
Updates sapphire build script.
402f374
Renames hephaestus to platypus.
f2cbdfb
alexanderianblair
alexanderianblair reviewed Jul 9, 2024
View reviewed changes
docker/platypus-deps/Dockerfile Outdated Show resolved Hide resolved
docker/platypus-deps/Dockerfile Outdated Show resolved Hide resolved
docker/platypus-deps/Dockerfile Outdated Show resolved Hide resolved
unit/Makefile Show resolved Hide resolved
Edward Palmer added 24 commits July 9, 2024 12:45
Removes cclake build script.
f1cab83
Removes duplicated environment variables in dockerfile.
e16585c
Fixes incorrect comments in platypus-deps dockerfile.
ce601a8
Fixes build script for sapphire rapids.
52ae7b0
Addresses hadolint DL3003 errors.
713f286
Addesses hadolint DL3003 errors in platypus Dockerfile.
788a080
Addresses DL3042.
44b5f7c
Addresses SC2006.
f7a7fe2
Adds global hadolint ignore rules.
84d8b0a
Fixes issues with platypus-deps Dockerfile.
734dc2a
Updates build script with "exit". More consistent.
eb04448
Removes superfluous forward slashes form CSD3 sapphire build script.
8bfc267
Removes SampleTest.
4fab005
Adds TestVariables.
eba2b55
Adds input parameters test.
fb7c149
Adds non linear integrator test.
3d99c49
Fixes white-space formatting issue.
ca654e0
Fixes formatting in sapphire build script.
89fa99f
Fixes incorrect padding in sapphire build script.
1d0e4a3
Addresses sapphire build script warnings.
7cfad0f
Updates platypus commit hash in sapphire build script.
827c4bd
Fixes SC1091 error.
7769fe8
Changes permissions using chmod for sapphire build script.
ac55fa8
Comments-out failing tests.
feb14e4 
The multi-element distributed tests are failing after a recent MOOSE update (no libmesh change).
alexanderianblair
alexanderianblair approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@alexanderianblair alexanderianblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to a notable drop in test coverage - but that's somewhat expected given the number of new files being added (and that some of the tests that rely on AuxSolvers that we are not adding to this version of Platypus haven't been ported).

As we're building this up - I think it makes sense to merge this in, and then extend the tests as we replace/update the old hephaestus files to follow MOOSE conventions, since that is much easier for the team to chip away at.

@alexanderianblair alexanderianblair merged commit 86c70c4 into main Jul 11, 2024
13 of 14 checks passed
@alexanderianblair alexanderianblair deleted the EdwardPalmer99/remove-hephaestus-dependency branch July 14, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderianblair alexanderianblair alexanderianblair approved these changes

Assignees

@EdwardPalmer99 EdwardPalmer99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwardPalmer99 @alexanderianblair