-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify diffusion test into single test file #16
Merged
alexanderianblair
merged 12 commits into
main
from
alexanderianblair/simplify-diffusion-test
Jul 30, 2024
Merged
Simplify diffusion test into single test file #16
alexanderianblair
merged 12 commits into
main
from
alexanderianblair/simplify-diffusion-test
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
Note - code coverage is erroneously low for this PR as the CI is skipping the new diffusion test, since |
…sh in diffusion test
Heinrich-BR
reviewed
Jul 29, 2024
Heinrich-BR
approved these changes
Jul 30, 2024
alexanderianblair
deleted the
alexanderianblair/simplify-diffusion-test
branch
August 12, 2024 15:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the diffusion regression test being used in Platypus solved both an MFEM and MOOSE variation of the problem, and compared the outputs via the L2 error norm, which required a MultiApp simulation and a Transfer to be called. This obfuscates the steps of the user setup of the MFEM FE problem.
This PR updates this test to consist of a single test file that uses MOOSE's VTKDiff tester to compare the output .pvtu files against reference data. It also removes the version of the diffusion problem in
test/tests/outputs
that was an effective duplicate of the main regression test for usage of the diffusion integrator intest/tests/kernels
.A minor fix to the registered base identifier in MFEMVariable has also been applied, to ensure MFEM variables can be added as AuxVariables to the problem as before.
Additionally, an option to specify the VTK output format has been added to the ParaView DataCollection wrapper. This is to allow an ASCII format to be used for tests with small output file sizes, which facilitates easier diagnosis of issues upon test failure and appears more robust when running MOOSE's XMLDiff tests on different systems, at the expense of test runtime.