Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test coverage information to coverage reports #15

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

alexanderianblair
Copy link
Contributor

@alexanderianblair alexanderianblair commented Jul 18, 2024

Currently, Platypus unit tests are not built or run in the Docker build (only regression tests are), and as such, do not contribute towards the total test coverage of Platypus. This PR adds the build and running of the existing unit tests to the Platypus Dockerfile.

Also adds missing MFEM mesh (beam-tet.mesh) required for unit tests, and moves regression tests from test/tests/unit to test/tests, to make Platypus consistent with MOOSE's current test directory structure and avoid confusion with the unit tests that are now contributing to coverage.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 8 files with indirect coverage changes

… with unit tests in platypus/unit, and follow current MOOSE test directory structure convention
Copy link
Collaborator

@Heinrich-BR Heinrich-BR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexanderianblair alexanderianblair removed the request for review from cmacmackin July 19, 2024 13:35
@alexanderianblair alexanderianblair merged commit f190f9e into main Jul 19, 2024
14 checks passed
@alexanderianblair alexanderianblair deleted the alexanderianblair/unit-test-coverage branch August 12, 2024 15:25
loganharbour pushed a commit to loganharbour/platypus that referenced this pull request Jan 7, 2025
…exanderianblair/unit-test-coverage

Add unit test coverage information to coverage reports
loganharbour pushed a commit to loganharbour/platypus that referenced this pull request Jan 7, 2025
…exanderianblair/unit-test-coverage

Add unit test coverage information to coverage reports
loganharbour pushed a commit to loganharbour/platypus that referenced this pull request Jan 14, 2025
…exanderianblair/unit-test-coverage

Add unit test coverage information to coverage reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants