Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifies ProblemBuilders and Converts Problem to a Struct #10

Closed
wants to merge 26 commits into from
Closed

Simplifies ProblemBuilders and Converts Problem to a Struct #10

wants to merge 26 commits into from

Conversation

EdwardPalmer99
Copy link

Brief

  • Problem class has been renamed to MFEMProblemData and converted to a struct.
  • Removes Problem derived classes and methods.
  • Problem builders are simplified.
  • Problem operators are moved-out from Problem class.

Edward Palmer added 23 commits July 11, 2024 12:37
Removes SetCoefficients method.
3391936
Removes SetJacobianSolver().
db0502f
Removes addBoundaryCondition method.
2197e08
Removes SetSolverOptions.
3850e8a
Removes SetOutputs.
c432547
Removes SetJacobianPreconditioner.
a429df1
Removes SetBoundaryConditions.
b5c1232
Removes RegisterFESpaces, RegisterCoefficients.
07d47c4
Removes SetMesh.
27c8930
Removes SetFESpaces, SetGridFunctions.
0326979
Removes AddFESpace, AddGridFunction.
429f137
Fixes compilation after removal of SetMesh.
84ea395
Moves ConstructOperator method directly into problem builders.
03d078b
Removes solver options from Problem.
4ddcdd2
Adds base class for the problem operator.
295e986
Adds ReturnOperator() method to ProblemOperatorBase.
ca577f6
Moves the problem operator out of the Problem classes.
d475473
Removes derived problem classes.
d4b87ae
Problem class is now a struct.
67ad04d
Renames "Problem" to "MFEMProblemData".
bbb4e3e
Simplifies ProblemOperator constructors.
9165c60
getMFEMMesh(), getMFEMParMesh() return shared pointers.
b56782a 
Clears-up ownership and dodgy use of shared pointers in MFEMProblem.
Removes TestVariables.
02c731b 
Problem builder has changed.
@EdwardPalmer99 EdwardPalmer99 changed the base branch from main to EdwardPalmer99/implement-fespaces-and-gridfunctions July 11, 2024 15:27
@EdwardPalmer99 EdwardPalmer99 changed the base branch from EdwardPalmer99/implement-fespaces-and-gridfunctions to EdwardPalmer99/implement-solvers July 11, 2024 15:27
@EdwardPalmer99 EdwardPalmer99 self-assigned this Jul 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 18 lines in your changes missing coverage. Please review.

Files Coverage Δ
src/executioners/transient_executioner.C 74.07% <100.00%> (ø)
src/fespaces/MFEMFESpace.C 100.00% <100.00%> (ø)
src/mesh/CoupledMFEMMesh.C 96.61% <100.00%> (ø)
src/problem_builders/problem_builder_base.C 100.00% <100.00%> (ø)
...ders/time_domain_equation_system_problem_builder.C 100.00% <100.00%> (ø)
src/solvers/MFEMHypreGMRESSolver.C 94.73% <100.00%> (ø)
src/mesh/ExclusiveMFEMMesh.C 36.11% <66.66%> (ø)
src/solvers/MFEMHypreFGMRESSolver.C 0.00% <0.00%> (ø)
src/solvers/MFEMHyprePCGSolver.C 0.00% <0.00%> (ø)
...ers/steady_state_equation_system_problem_builder.C 0.00% <0.00%> (ø)
... and 4 more

@EdwardPalmer99 EdwardPalmer99 deleted the EdwardPalmer99/merge-problem-builders-with-mfem-problem branch July 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@EdwardPalmer99 EdwardPalmer99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EdwardPalmer99