Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: extend EIP-7702 #73

Merged
merged 19 commits into from
Jan 14, 2025
Merged

Feat: extend EIP-7702 #73

merged 19 commits into from
Jan 14, 2025

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Dec 19, 2024

Description

After ethereum-pectra-devnet-5 release, EIP-7702 was changed.

This PR includes:
➡️ Gas cost changed
➡️ EXTCODE* behavior changed for designator
➡️ Added additional validation step.

@mrLSD mrLSD self-assigned this Dec 19, 2024
@mrLSD mrLSD changed the base branch from master to feat/prague-hard-fork December 19, 2024 21:53
@mrLSD mrLSD added hard-fork EIP HF-Prague Prague hard fork labels Dec 19, 2024
@mrLSD mrLSD added this to the v0.47.0-aurora milestone Jan 10, 2025
@mrLSD mrLSD requested review from aleksuss and birchmd January 10, 2025 20:40
evm-tests/jsontests/src/state.rs Outdated Show resolved Hide resolved
src/executor/stack/executor.rs Outdated Show resolved Hide resolved
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Member

@aleksuss aleksuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍🏻

state.set_code(authority.authority, Vec::new());
} else {
state.set_code(authority.authority, authority.delegation_code());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess rust-idiomatic here would be:

let delegation_clearing = if authority.address.is_zero() {
    state.set_code(authority.authority, Vec::new());
    true
} else {
	state.set_code(authority.authority, authority.delegation_code());
    false
};

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, thanks. It will be managed in the next PR that is already in progress.

@mrLSD mrLSD merged commit 22db6b5 into feat/prague-hard-fork Jan 14, 2025
11 checks passed
@mrLSD mrLSD deleted the feat/extend-eip-7702 branch January 14, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants