-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: extend EIP-7702 #73
Conversation
…nikvm into feat/extend-eip-7702
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good 👍🏻
state.set_code(authority.authority, Vec::new()); | ||
} else { | ||
state.set_code(authority.authority, authority.delegation_code()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess rust-idiomatic here would be:
let delegation_clearing = if authority.address.is_zero() {
state.set_code(authority.authority, Vec::new());
true
} else {
state.set_code(authority.authority, authority.delegation_code());
false
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯, thanks. It will be managed in the next PR that is already in progress.
Description
After
ethereum-pectra-devnet-5
release, EIP-7702 was changed.This PR includes:
➡️ Gas cost changed
➡️
EXTCODE*
behavior changed for designator➡️ Added additional validation step.