Update to Rust 1.84 and fix clippy (#74)

evm-tests/EIP-152/src/portable.rs

@@ -18,7 +18,7 @@
 
 use crate::{IV, SIGMA};
 
-/// The G mixing function. See https://tools.ietf.org/html/rfc7693#section-3.1
+/// The G mixing function. See <https://tools.ietf.org/html/rfc7693#section-3.1>
 #[inline(always)]
 fn g(v: &mut [u64], a: usize, b: usize, c: usize, d: usize, x: u64, y: u64) {
 	v[a] = v[a].wrapping_add(v[b]).wrapping_add(x);

evm-tests/ethjson/src/bytes.rs

@@ -84,7 +84,7 @@ impl<'a> Deserialize<'a> for Bytes {
 
 struct BytesVisitor;
 
-impl<'a> Visitor<'a> for BytesVisitor {
+impl Visitor<'_> for BytesVisitor {
 	type Value = Bytes;
 
 	fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

evm-tests/ethjson/src/uint.rs

@@ -64,7 +64,7 @@ impl<'a> Deserialize<'a> for Uint {
 
 struct UintVisitor;
 
-impl<'a> Visitor<'a> for UintVisitor {
+impl Visitor<'_> for UintVisitor {
 	type Value = Uint;
 
 	fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

fuzzer/src/main.rs

@@ -2,9 +2,9 @@ use evm_core::Machine;
 use std::rc::Rc;
 
 fn find_subsequence(haystack: &[u8], needle: &[u8]) -> Option<usize> {
-	return haystack
+	haystack
 		.windows(needle.len())
-		.position(|window| window == needle);
+		.position(|window| window == needle)
 }
 
 fn split_at_delim(sequence: &[u8], delim: &[u8]) -> (Vec<u8>, Vec<u8>) {

gasometer/src/lib.rs

@@ -878,7 +878,7 @@ struct Inner<'config> {
 	config: &'config Config,
 }
 
-impl<'config> Inner<'config> {
+impl Inner<'_> {
 	fn memory_gas(&self, memory: MemoryCost) -> Result<u64, ExitError> {
 		let from = memory.offset;
 		let len = memory.len;

rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.82.0"
+channel = "1.84.0"
 profile = "minimal"
 components = ["rustfmt", "clippy"]

src/backend/memory.rs

@@ -96,7 +96,7 @@ impl<'vicinity> MemoryBackend<'vicinity> {
 	}
 }
 
-impl<'vicinity> Backend for MemoryBackend<'vicinity> {
+impl Backend for MemoryBackend<'_> {
 	#[allow(clippy::misnamed_getters)]
 	fn gas_price(&self) -> U256 {
 		self.vicinity.effective_gas_price
@@ -186,7 +186,7 @@ impl<'vicinity> Backend for MemoryBackend<'vicinity> {
 	}
 }
 
-impl<'vicinity> ApplyBackend for MemoryBackend<'vicinity> {
+impl ApplyBackend for MemoryBackend<'_> {
 	fn apply<A, I, L>(&mut self, values: A, logs: L, delete_empty: bool)
 	where
 		A: IntoIterator<Item = Apply<I>>,

src/executor/stack/executor.rs

@@ -1157,8 +1157,8 @@ impl<'config, 'precompiles, S: StackState<'config>, P: PrecompileSet>
 	}
 }
 
-impl<'config, 'precompiles, S: StackState<'config>, P: PrecompileSet> InterpreterHandler
-	for StackExecutor<'config, 'precompiles, S, P>
+impl<'config, S: StackState<'config>, P: PrecompileSet> InterpreterHandler
+	for StackExecutor<'config, '_, S, P>
 {
 	#[inline]
 	fn before_eval(&mut self) {}
@@ -1248,8 +1248,8 @@ pub struct StackExecutorCallInterrupt<'borrow>(TaggedRuntime<'borrow>);
 
 pub struct StackExecutorCreateInterrupt<'borrow>(TaggedRuntime<'borrow>);
 
-impl<'config, 'precompiles, S: StackState<'config>, P: PrecompileSet> Handler
-	for StackExecutor<'config, 'precompiles, S, P>
+impl<'config, S: StackState<'config>, P: PrecompileSet> Handler
+	for StackExecutor<'config, '_, S, P>
 {
 	type CreateInterrupt = StackExecutorCreateInterrupt<'static>;
 	type CreateFeedback = Infallible;
@@ -1543,8 +1543,8 @@ struct StackExecutorHandle<'inner, 'config, 'precompiles, S, P> {
 	is_static: bool,
 }
 
-impl<'inner, 'config, 'precompiles, S: StackState<'config>, P: PrecompileSet> PrecompileHandle
-	for StackExecutorHandle<'inner, 'config, 'precompiles, S, P>
+impl<'config, S: StackState<'config>, P: PrecompileSet> PrecompileHandle
+	for StackExecutorHandle<'_, 'config, '_, S, P>
 {
 	// Perform subcall in provided context.
 	/// Precompile specifies in which context the subcall is executed.

src/executor/stack/memory.rs

@@ -499,7 +499,7 @@ pub struct MemoryStackState<'backend, 'config, B> {
 	substate: MemoryStackSubstate<'config>,
 }
 
-impl<'backend, 'config, B: Backend> Backend for MemoryStackState<'backend, 'config, B> {
+impl<B: Backend> Backend for MemoryStackState<'_, '_, B> {
 	fn gas_price(&self) -> U256 {
 		self.backend.gas_price()
 	}
@@ -576,7 +576,7 @@ impl<'backend, 'config, B: Backend> Backend for MemoryStackState<'backend, 'conf
 	}
 }
 
-impl<'backend, 'config, B: Backend> StackState<'config> for MemoryStackState<'backend, 'config, B> {
+impl<'config, B: Backend> StackState<'config> for MemoryStackState<'_, 'config, B> {
 	fn metadata(&self) -> &StackSubstateMetadata<'config> {
 		self.substate.metadata()
 	}

src/maybe_borrowed.rs

@@ -14,7 +14,7 @@ pub enum MaybeBorrowed<'a, T> {
 	Owned(T),
 }
 
-impl<'a, T> core::ops::Deref for MaybeBorrowed<'a, T> {
+impl<T> core::ops::Deref for MaybeBorrowed<'_, T> {
 	type Target = T;
 
 	fn deref(&self) -> &Self::Target {
@@ -25,7 +25,7 @@ impl<'a, T> core::ops::Deref for MaybeBorrowed<'a, T> {
 	}
 }
 
-impl<'a, T> core::ops::DerefMut for MaybeBorrowed<'a, T> {
+impl<T> core::ops::DerefMut for MaybeBorrowed<'_, T> {
 	fn deref_mut(&mut self) -> &mut Self::Target {
 		match self {
 			Self::Borrowed(x) => x,