Skip to content

Commit

Permalink
Remove TODO for CREATE tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mrLSD committed Jan 13, 2025
1 parent 0e4639a commit 0a2b4cf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
4 changes: 1 addition & 3 deletions evm-tests/jsontests/src/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -942,9 +942,7 @@ fn check_validate_exit_reason(
) -> bool {
expect_exception.as_deref().map_or_else(
|| {
// TODO: dev-pectra-5 tests
true
// panic!("unexpected validation error reason: {reason:?} {name}");
panic!("unexpected validation error reason: {reason:?} {name}");
},
|exception| {
match reason {
Expand Down
9 changes: 0 additions & 9 deletions evm-tests/jsontests/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -447,15 +447,6 @@ pub mod transaction {
return Err(InvalidTxReason::AuthorizationListNotExist);
}

// The field `to` deviates slightly from the semantics with the exception
// that it MUST NOT be nil and therefore must always represent
// a 20-byte address. This means that blob transactions cannot
// have the form of a create transaction.
let to_address: Option<Address> = test_tx.to.clone().into();
if to_address.is_none() {
return Err(InvalidTxReason::CreateTransaction);
}

// Check EIP-7702 Spec validation steps: 1 and 2
// Other validation step inside EVM transact logic.
for auth in test_tx.authorization_list.iter() {
Expand Down

0 comments on commit 0a2b4cf

Please sign in to comment.