-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sort func schemas and metadata in diffs #473
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
+ Coverage 73.47% 73.51% +0.03%
==========================================
Files 43 43
Lines 3540 3545 +5
==========================================
+ Hits 2601 2606 +5
Misses 939 939 ☔ View full report in Codecov by Sentry. |
PR Type
Bug fix
Description
Changes walkthrough 📝
schema.py
Sort function schemas and metadata for consistent diffs
semantic_router/schema.py
function_schemas
andmetadata
usingjson.dumps
withsort_keys=True
.for accurate comparison.