Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies the console input to test out rqt #374

Merged
merged 1 commit into from
May 17, 2023
Merged

Modifies the console input to test out rqt #374

merged 1 commit into from
May 17, 2023

Conversation

Voldivh
Copy link

@Voldivh Voldivh commented May 17, 2023

This PR modifies the console input to run rqt according to the discussions made ros-visualization/rqt#270 and ros-visualization/rqt#293.

At the moment, the only command that works in linux and windows in order to use rqt is rqt, we believe it makes sense to just set that command as the default executable. Taking into account that on windows the command ros2 run rqt_gui rqt_gui does not work due to it being a .py file instead of a .exe file, it makes sense to suggest the only command that works on both platforms.

@mergify mergify bot merged commit b1abb8b into audrow:iron May 17, 2023
@Voldivh Voldivh deleted the voldivh/modify_stdin_to_rqt branch May 17, 2023 16:59
Yadunund pushed a commit that referenced this pull request Jun 20, 2023
Yadunund added a commit that referenced this pull request Jul 13, 2023
* move humble requirements to root

Signed-off-by: Yadunund <[email protected]>

* Update tier 3 os labels and remove source from jammy

Signed-off-by: Yadunund <[email protected]>

* Tmp fix for redirected links in sitemap that cause duplicate requirements

Signed-off-by: Yadunund <[email protected]>

* Added an expectation for param delete

Signed-off-by: Yadunund <[email protected]>

* Fix prompt for service find

Signed-off-by: Yadunund <[email protected]>

* Update bag info with mcap

Signed-off-by: Yadunund <[email protected]>

* Added details for component cli tests

Signed-off-by: Yadunund <[email protected]>

* Add checks for ros1_bridge

Signed-off-by: Yadunund <[email protected]>

* Added tests for service introspection

Signed-off-by: Yadunund <[email protected]>

* Add check for asunc_param_client

Signed-off-by: Yadunund <[email protected]>

* Fix duplicate py checks

Signed-off-by: Yadunund <[email protected]>

* Add DISTRO_LABEL constant

Signed-off-by: Yadunund <[email protected]>

* Use DISTRO const to retrieve docs

Signed-off-by: Yadunund <[email protected]>

* Change the names of launch files to be _launch.py (#347)

This matches the current best practice, which we updated
in Iron.

Signed-off-by: Chris Lalancette <[email protected]>

* Update the service executables demon_nodes_py test to use async. (#348)

There is no '_sync' version, so this must have been a typo for
the '_async' version, which does exist.

Signed-off-by: Chris Lalancette <[email protected]>

* Add the holonomic parameter to turtlesim tests. (#350)

Signed-off-by: Chris Lalancette <[email protected]>

* remove extra slash to output correct command (#353)

Signed-off-by: Chen Lihui <[email protected]>

* fix input (#352)

Signed-off-by: Yadunund <[email protected]>

* Add linux label to realtime tests (#351)

Signed-off-by: Yadunund <[email protected]>

* tag linux (#357)

Signed-off-by: Yadunund <[email protected]>

* Fix up the multicast test to have a try and expect section. (#355)

Signed-off-by: Chris Lalancette <[email protected]>

* Add in a missing component container name in a test. (#354)

Signed-off-by: Chris Lalancette <[email protected]>

* Specify frame ids for static transform publisher (#358)

Signed-off-by: Yadunund <[email protected]>

* Replace executables with link to demos readme (#365)

* Replace executables with link to demos readme

Signed-off-by: Yadunund <[email protected]>

* address feedback

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>

* Change references to humble -> iron (#370)

Signed-off-by: Chris Lalancette <[email protected]>

* Modifies the console input to test out rqt (#374)

Signed-off-by: Voldivh <[email protected]>

* Adds the label to only test in linux gazebo_ros_pkgs (#392)

Signed-off-by: Voldivh <[email protected]>

* Removes test cases for Windows (#394)

Signed-off-by: Voldivh <[email protected]>

* Adds a clearer description for the idl message generation (#390)

* Adds a clearer description of the test

Signed-off-by: Voldivh <[email protected]>

* Replace executables with link to demos readme  (#395)

* Replace executables with link to demos readme

Signed-off-by: Voldivh <[email protected]>

* Adds the full path to the launch testing stdin (#393)

* Adds the full path to the launch testing stdin

* Adds instructions to clone the repository

Signed-off-by: Voldivh <[email protected]>

* Filter redirects in docs.ros.org sitemap (#405)

* Ignore redirects

Signed-off-by: Yadunund <[email protected]>

* Moved iron requirements to ros2_test_cases

Signed-off-by: Yadunund <[email protected]>

* Restore garden backup

Signed-off-by: Yadunund <[email protected]>

* Parse YAML_DISTRO_LABEL

Signed-off-by: Yadunund <[email protected]>

* Update readme and ci

Signed-off-by: Yadunund <[email protected]>

* Format

Signed-off-by: Yadunund <[email protected]>

* Make YATM_DISTRO_LABEL a required param

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Co-authored-by: Yadunund <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chen Lihui <[email protected]>
Co-authored-by: Eloy Briceno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants