Skip to content

Commit

Permalink
test: fix errors in shellcheck's tests
Browse files Browse the repository at this point in the history
  • Loading branch information
attilasomogyi committed Mar 29, 2023
1 parent fece5d5 commit c00fe01
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 7 deletions.
1 change: 0 additions & 1 deletion .shellcheckrc
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
disable=SC2155,SC1090
severity=warning
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ Please read and follow our [Code of Conduct][coc].

Do not open issues for general support questions as we want to keep GitHub
issues for bug reports and feature requests. Instead, we recommend using [Stack
Overflow](https://stackoverflow.com/questions/tagged/asterisk-configuration-files) to ask
Overflow](https://stackoverflow.com/questions/tagged/asterisk) to ask
support-related questions. When creating a new question on Stack Overflow, make
sure to add the `asterisk-configuration-files` tag.
sure to add the `asterisk` tag.

Stack Overflow is a much better place to ask questions since:

Expand Down
4 changes: 2 additions & 2 deletions SUPPORT.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ But if you have any questions.

Do not open issues for general support questions as we want to keep GitHub
issues for bug reports and feature requests. Instead, we recommend using [Stack
Overflow](https://stackoverflow.com/questions/tagged/asterisk-configuration-files) to ask
Overflow](https://stackoverflow.com/questions/tagged/asterisk) to ask
support-related questions. When creating a new question on Stack Overflow, make
sure to add the `asterisk-configuration-files` tag.
sure to add the `asterisk` tag.

Stack Overflow is a much better place to ask questions since:

Expand Down
1 change: 1 addition & 0 deletions tests/static/static.bats
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@ load test_helper/static.bash
print_errors
[ "$status" -eq 0 ]
}

4 changes: 3 additions & 1 deletion tests/static/test_helper/static.bash
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
#!/usr/bin/env bash

# shellcheck disable=SC2154
function print_errors() {
for line in "${lines[@]}"; do
echo "$line"
done
}
# shellcheck enable=all

function shellcheck_test() {
shellcheck_url="https://github.com/koalaman/shellcheck"
Expand All @@ -14,7 +16,7 @@ function shellcheck_test() {
exit 1
}

scripts=$(find . -name '*.sh' -name '*.bash')
scripts=$(git ls-files --cached --modified --other --exclude-standard --deduplicate | grep --extended-regexp '\.sh$|\.bash$')
for script in $scripts; do
shellcheck "$script"
done
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,7 @@ [email protected]:
mdurl "^1.0.1"
uc.micro "^1.0.5"

markdownlint-cli@^0.33.0:
markdownlint-cli@latest:
version "0.33.0"
resolved "https://registry.yarnpkg.com/markdownlint-cli/-/markdownlint-cli-0.33.0.tgz#703af1234c32c309ab52fcd0e8bc797a34e2b096"
integrity sha512-zMK1oHpjYkhjO+94+ngARiBBrRDEUMzooDHBAHtmEIJ9oYddd9l3chCReY2mPlecwH7gflQp1ApilTo+o0zopQ==
Expand Down

0 comments on commit c00fe01

Please sign in to comment.