Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #275 #276

Merged
merged 3 commits into from
Dec 10, 2024

Merge branch 'main' into gh_issue_275

16f2e5e
Select commit
Loading
Failed to load commit list.
Merged

Closes #275 #276

Merge branch 'main' into gh_issue_275
16f2e5e
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 10, 2024 in 0s

15 / 15 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
The spirit of xportr is met in your Pull Request Completed
Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update) Completed
Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory. Completed
Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly. Completed
New functions or arguments follow established convention found in the Wiki. Completed
Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package. Completed
Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package. Completed
Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately Completed
Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page. Completed
Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers) Completed
The NEWS.md entry should go under the # xportr development version section. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI. Completed
Address any updates needed for vignettes and/or templates. Completed
Link the issue Development Panel so that it closes after successful merging. Completed
The developer is responsible for fixing merge conflicts not the Reviewer. Completed
Pat yourself on the back for a job well done! Much love to your accomplishment! Completed
View more details on Task list completed