Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #175 Adds assertions to exported functions #190

Merged
merged 36 commits into from
Jan 23, 2024

revert: no longer retrieve metadata attribute as default

9836f8b
Select commit
Loading
Failed to load commit list.
Merged

Closes #175 Adds assertions to exported functions #190

revert: no longer retrieve metadata attribute as default
9836f8b
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jan 23, 2024 in 0s

18 / 18 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Closes #175 Incomplete
Adds dependency checkmate Incomplete
Asserts parameters of all exported functions Incomplete
Standard error message for complex assertions (non-ascii characters, ...) Incomplete
Changes default parameters to retrieve data.frame attributes (domain, metadata) instead of NULL Incomplete
Add assertions to all exported functions Completed
Leverage checkmate::test_* for consistent tests Completed
Add documentation to wiki Completed
Keep test coverage at 100% Completed
The spirit of xportr is met in your Pull Request Completed
Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update) Completed
Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory. Completed
Check that your Pull Request is targeting the devel branch, Pull Requests to main should use the Release Pull Request Template Completed
Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly. Completed
Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package. Completed
Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package. Completed
Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately Completed
Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page. Completed
Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers) Completed
Address any updates needed for vignettes and/or templates Completed
Link the issue Development Panel so that it closes after successful merging. Completed
Fix merge conflicts Completed
Pat yourself on the back for a job well done! Much love to your accomplishment! Completed
attr(.df, "_xportr.<name>_") instead of NULL Incomplete
attr(.df, xportr.) instead of NULL` Incomplete